Re: [PATCH] Add support for GnuTLS - Mailing list pgsql-patches

From Martijn van Oosterhout
Subject Re: [PATCH] Add support for GnuTLS
Date
Msg-id 20060506183445.GD4413@svana.org
Whole thread Raw
In response to Re: [PATCH] Add support for GnuTLS  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [PATCH] Add support for GnuTLS  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
On Sat, May 06, 2006 at 01:11:26PM -0400, Bruce Momjian wrote:
>
> This is a pretty massive patch, but I understand the license concerns.
> Is this what we want to do?

More than half the patch is simply moving the OpenSSL related stuff
from fe/be-secure.c to fe/be-secure-openssl.c. If you create the
-openssl versions first you can more easily see that the changes are in
fact quite minor. Unfortunatly diff can't represent the change "copy N
lines from file A to file B" very efficiently.

If you like I can split it into two patches, one patch splits the openssl
stuff out of the main files and a second which adds gnutls support.

> FYI, yesterday's SSL CRL additions need to be added to this patch.

I saw them. I've already added them to my local version, including the
corresponding changes for GnuTLS. I was going to wait a few days before
sending a new version, in case any more changes came down the line.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

Attachment

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: plpython improvements
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCH] Add support for GnuTLS