pgsql: Comments in IndexBuildHeapScan describe the indexing of - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Comments in IndexBuildHeapScan describe the indexing of
Date
Msg-id 20060324230223.AD1EB9DCC9D@postgresql.org
Whole thread Raw
Responses Re: pgsql: Comments in IndexBuildHeapScan describe  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-committers
Log Message:
-----------
Comments in IndexBuildHeapScan describe the indexing of recently-dead
tuples as needed "to keep VACUUM from complaining", but actually there is
a more compelling reason to do it: failure to do so violates MVCC semantics.
This is because a pre-existing serializable transaction might try to use
the index after we finish (re)building it, and it might fail to find tuples
it should be able to see.  We got this mostly right, but not in the case
of partial indexes: the code mistakenly discarded recently-dead tuples for
partial indexes.  Fix that, and adjust the comments.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/src/backend/catalog:
        index.c (r1.261.2.1 -> r1.261.2.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/index.c.diff?r1=1.261.2.1&r2=1.261.2.2)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Comments in IndexBuildHeapScan describe the indexing of
Next
From: ksrikanth@pgfoundry.org (User Ksrikanth)
Date:
Subject: bizgres - bizgres: Introduce release Release-0_9_0