Re: [GENERAL] Number format problem - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [GENERAL] Number format problem
Date
Msg-id 200602130258.k1D2wo209084@candle.pha.pa.us
Whole thread Raw
In response to Re: [GENERAL] Number format problem  ("Daniel Verite" <daniel@manitou-mail.org>)
List pgsql-patches
Daniel Verite wrote:
>     Bruce Momjian wrote:
>
> > > > Oh, so C locale has "" for thousands_sep?  Hmm.  So there is no way to
> > > > disinguish "" as "don't have" from "" as "don't want".  Will revert.
> > >
> > > Possibly we could special-case C locale, and allow an empty string only
> > > when not C locale.  However, it could be that there are other locales
> > > where the change would surprise people, too :-(
> >
> > Not sure.  Peter stated the French locale was wrong for the Debian they
> > were using, and he should know, so I am going to wait for  more feeback.
>
> The baseline glibc sources from gnu.org have
> (in glibc-2.3.6/localedata/locales/fr_FR):
>
> LC_NUMERIC
> decimal_point             "<U002C>"
> thousands_sep             ""
> grouping                  0;0
> END LC_NUMERIC
>
> So at first sight it's more a glibc issue rather than debian-specific.
>
> However, this was filed as a bug in debian long ago. Incidentally, it got fixed
> just this week, meaning that the future debian-glibc should use a space instead
> of the empty string, as reported here:
> http://lists.debian.org/debian-glibc/2006/02/msg00168.html
> Which is consistent with Peter's statement that it was wrong up to now, and also
> with what the OP expected in the first place.

Oh, good.  I looked and now realize that psql is already checking for a
non-"" string:

        if (*extlconv->thousands_sep)

so we are consistent.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Free WAL caches on switching segments
Next
From: "Sergey E. Koposov"
Date:
Subject: patch correcting the build failure on machines without readline