Re: [GENERAL] Number format problem - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [GENERAL] Number format problem
Date
Msg-id 200602122356.k1CNuFj14534@candle.pha.pa.us
Whole thread Raw
In response to Re: [GENERAL] Number format problem  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [GENERAL] Number format problem  ("Daniel Verite" <daniel@manitou-mail.org>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> This patch broke the regression tests.  It seems to change the C-locale
> >> behavior on many platforms.
>
> > Oh, so C locale has "" for thousands_sep?  Hmm.  So there is no way to
> > disinguish "" as "don't have" from "" as "don't want".  Will revert.
>
> Possibly we could special-case C locale, and allow an empty string only
> when not C locale.  However, it could be that there are other locales
> where the change would surprise people, too :-(

Not sure.  Peter stated the French locale was wrong for the Debian they
were using, and he should know, so I am going to wait for  more feeback.

One thing that has me confused is that psql/print.c doesn't check for a
zero-length string for thousands_sep in setDecimalLocale, so I am not
thinking that is wrong and should skip "" like we do in formatting.c.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [GENERAL] Number format problem
Next
From: Bruce Momjian
Date:
Subject: Re: [GENERAL] Number format problem