Re: [HACKERS] Spaces in psql output (Was: FW: PGBuildfarm - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Spaces in psql output (Was: FW: PGBuildfarm
Date
Msg-id 200602121635.k1CGZLK19996@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Spaces in psql output (Was: FW: PGBuildfarm
List pgsql-patches
Tom Lane wrote:
> Martijn van Oosterhout <kleptog@svana.org> writes:
> > About the ReportSyntaxErrorPosition thing, it was considered at the
> > time (can't find the email right now) that control characters would be
> > problematic but it wouldn't break anything that wasn't broken already.
> > How tab was missed I don't know, nor a couple of other failures cases
> > I've thought of since. Thanks for fixing that.
>
> What I was thinking of doing was making it translate any control
> character (other than \r and \n) to a space, not only tab.  However
> this should probably wait on the result of the discussion about whether
> we really like the \x09 output for tabs in data ... that might yield an
> idea that could be applied here too.

Perhaps we should just output "\009" for tab and "\xxx" for other
control characters.  That seems the most natural.  I can't see why we
would convert every control character to " ".

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)
Next
From: "Sergey E. Koposov"
Date:
Subject: patch fixing the old RETURN NEXT bug