Re: In pg_dump "no owner" mode don't dump owner names in comments - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: In pg_dump "no owner" mode don't dump owner names in comments
Date
Msg-id 200602092051.k19Kpsg03934@candle.pha.pa.us
Whole thread Raw
In response to In pg_dump "no owner" mode don't dump owner names in comments  (Christopher Kings-Lynne <chriskl@familyhealth.com.au>)
List pgsql-patches
Patch applied.  Thanks.

---------------------------------------------------------------------------


Christopher Kings-Lynne wrote:
> This fixes pg_dump so that when using the '-O' no owners option it does
> not print the owner name in the object comment.
>
> eg:
>
> --
> -- Name: actor; Type: TABLE; Schema: public; Owner: chriskl; Tablespace:
> --
>
> Becomes:
>
> --
> -- Name: actor; Type: TABLE; Schema: public; Owner: -; Tablespace:
> --
>
> This makes it far easier to do 'user independent' dumps.  Especially for
> distribution to third parties.
>
> Chris

> Index: src/bin/pg_dump/pg_backup_archiver.c
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/bin/pg_dump/pg_backup_archiver.c,v
> retrieving revision 1.117
> diff -c -r1.117 pg_backup_archiver.c
> *** src/bin/pg_dump/pg_backup_archiver.c    15 Oct 2005 02:49:38 -0000    1.117
> --- src/bin/pg_dump/pg_backup_archiver.c    21 Nov 2005 07:19:39 -0000
> ***************
> *** 2404,2410 ****
>           ahprintf(AH, "-- %sName: %s; Type: %s; Schema: %s; Owner: %s",
>                    pfx, te->tag, te->desc,
>                    te->namespace ? te->namespace : "-",
> !                  te->owner);
>           if (te->tablespace)
>               ahprintf(AH, "; Tablespace: %s", te->tablespace);
>           ahprintf(AH, "\n");
> --- 2404,2410 ----
>           ahprintf(AH, "-- %sName: %s; Type: %s; Schema: %s; Owner: %s",
>                    pfx, te->tag, te->desc,
>                    te->namespace ? te->namespace : "-",
> !                  ropt->noOwner ? "-" : te->owner);
>           if (te->tablespace)
>               ahprintf(AH, "; Tablespace: %s", te->tablespace);
>           ahprintf(AH, "\n");

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faq

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: contrib/xinetops for 8.1 "patch"
Next
From: Tom Lane
Date:
Subject: Re: contrib/xinetops for 8.1 "patch"