Logging statements and parameter values - Mailing list pgsql-general

From Ted Powell
Subject Logging statements and parameter values
Date
Msg-id 20060127060147.GA4795@theplace.enposte.net
Whole thread Raw
Responses Re: Logging statements and parameter values  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Logging statements and parameter values  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-general
Our development group needs to have the option of logging all SQL
statements including substituted parameter values. Getting output in the
form:
    ... WHERE contact.login_con = $1 AND company.login_co = $2

was no problem, but nothing that I tried turning on in the config file
yielded values for $1 and $2.

Digging into the source for 8.1.1 brought me to this code in
.../backend/tcop/postgres.c (lines 1449+)

        /* We need to output the parameter values someday */
        if (log_statement == LOGSTMT_ALL)
            ereport(LOG,
                    (errmsg("statement: <BIND> %s", portal_name)));

        /*
         * Fetch parameters, if any, and store in the portal's memory context.
         */
        if (numParams > 0)

It seems to me that a point near the bottom of the loop over parameters
(1564+)
            params[i].kind = PARAM_NUM;
            params[i].id = i + 1;
            params[i].ptype = ptype;
            params[i].isnull = isNull;

            i++;
        }

(params[i].value is set in a couple of places higher up in the loop)
would be a good place to log each parameter, but...

Has this not been done simply because nobody has gotten around to it, or
are there pitfalls? Although I've been using PostgreSQL for several years,
this is my first venture into its source code beyond watching it build.

Also, the Datum params[i].value, does it necessarily hold displayable
text, even when its content is the output of a binary input converter?
Is there a utility log routine somewhere that I can simply feed a
Datum to?


--
Ted Powell <ted@psg.com>   http://psg.com/~ted/
    GPL code ... It's the difference between
    owning your own home and just renting.  --PJ

pgsql-general by date:

Previous
From: "Ben Trewern"
Date:
Subject: Re: Alternative to knoda, kexi and rekall?
Next
From: Pedro Monjo Florit
Date:
Subject: Change SERIAL to INTEGER