Re: BUG #17886: Error disabling user triggers on a partitioned table - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #17886: Error disabling user triggers on a partitioned table
Date
Msg-id 2005410.1680713849@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #17886: Error disabling user triggers on a partitioned table  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-bugs
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2023-Apr-04, Tom Lane wrote:
>> I'm inclined to think that in the older branches (pre f4566345c)
>> we need to do
>> -       if (oldtrig->tgisinternal)
>> +       if (oldtrig->tgisinternal && !OidIsValid(oldtrig->tgparentid))
>> but I've not tested that.  Alvaro, what do you think?

> Oh, that's a nice and clean solution.  I tested it (on 13 and 14) and it
> does solve the problem, and no regression tests fail, but I didn't try
> to break it further.  12 and back are unaffected, for lack of
> 86f575948c77.

Pushed, thanks for looking at it.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Mats Kindahl
Date:
Subject: Re: BUG #17876: Function width_bucket() for float8 input returns value out of range
Next
From: PG Bug reporting form
Date:
Subject: BUG #17887: EDB Community Installer for windows, locale selection not working properly