Re: CVS of 8.1.x MS-VC6 probrem. - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: CVS of 8.1.x MS-VC6 probrem.
Date
Msg-id 200512091445.jB9Eja827246@candle.pha.pa.us
Whole thread Raw
In response to Re: CVS of 8.1.x MS-VC6 probrem.  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-patches
Magnus Hagander wrote:
> > While I have applied your patch, I am now confused about
> > something. Your change was to pg_config.h.win32, which is
> > used only for WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C.
> >
> > The addition was:
> >
> >     /* use _snprintf and _vsnprintf */
> >     #define HAVE_DECL_SNPRINTF 1
> >     #define snprintf        _snprintf
> >     #define HAVE_DECL_VSNPRINTF 1
> >     #define vsnprintf       _vsnprintf
> >
> > Now, I think the problem is that with those defines, we will
> > not use our port/snprintf.c, meaning the %$ escapes for
> > language translation will not work for those builds.  I
> > realize the backend is the most important for messages, but
> > libpq and psql also have message translation.
>
> AFAIK we don't support NLS builds with MSVC anyway. (Check
> pg_config.h.win32, it has no #define NLS). So I don't think this is an
> issue.

Right, thanks.  Sorry for the confusion.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: CVS of 8.1.x MS-VC6 probrem.
Next
From: David Fetter
Date:
Subject: Re: Patch to allow contrib/pgbench files to have blank lines