Re: A few pgindent oddities - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: A few pgindent oddities
Date
Msg-id 200511230034.jAN0YvL14618@candle.pha.pa.us
Whole thread Raw
In response to Re: A few pgindent oddities  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian wrote:
> > And what happened here?
> 
> I saw this one to and was stumped at the cause.  We have other 'typedef
> enum' lines in the code which were not mangled, just this one.  Again,
> needs research.
> 
> > Index: src/interfaces/libpq/libpq-fe.h
> > ***************
> > *** 35,41 ****
> >   
> >   /* Application-visible enum types */
> >   
> > ! typedef enum
> >   {
> >       /*
> >        * Although it is okay to add to this list, values which become unused
> > --- 35,41 ----
> >   
> >   /* Application-visible enum types */
> >   
> > !             typedef enum
> >   {
> >       /*
> >        * Although it is okay to add to this list, values which become unused

Ah the cause of this one is this at the top of src/interfaces/libpq/libpq-fe.h:
#ifdef __cplusplusextern      "C"{#endif

Not sure I can blame pgindent.  Of course the fact that the other
'typedef enum' lines in the file are not indented isn't consistent.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: A few pgindent oddities
Next
From: Alvaro Herrera
Date:
Subject: Re: tablespaces and non-empty directories