Another pgindent gripe - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Another pgindent gripe
Date
Msg-id 20051107121940.GB12167@surnet.cl
Whole thread Raw
Responses Re: Another pgindent gripe  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Another pgindent gripe  (Neil Conway <neilc@samurai.com>)
List pgsql-hackers
Hi,

I have another gripe regarding pgindent.  Why does it change indenting
of function declarations?  An example is at the end.  I think it may be
thinking that declarations should be aligned using 8-spaces tabs.  Can
this be corrected?

It annoyed me just now, because I'm adjusting my vacuum patch and lots
of conflicts appeared because it chose to change the spacing.  A
pointless change for an automatic tool to make, if I must add, and one
that adds gratuituous work for the human wanting to do some real work.


Index: vacuum.c
===================================================================
RCS file: /home/alvherre/cvs/pgsql/src/backend/commands/vacuum.c,v
retrieving revision 1.316
retrieving revision 1.317
diff -c -r1.316 -r1.317
*** vacuum.c    3 Oct 2005 22:52:21 -0000    1.316
--- vacuum.c    15 Oct 2005 02:49:16 -0000    1.317
***************
*** 198,204 ****  /* non-export function prototypes */ static List *get_rel_oids(List *relids, const RangeVar *vacrel,
!                           const char *stmttype); static void vac_update_dbstats(Oid dbid,
TransactionIdvacuumXID,                    TransactionId frozenXID);
 
--- 198,204 ----  /* non-export function prototypes */ static List *get_rel_oids(List *relids, const RangeVar *vacrel,
!              const char *stmttype); static void vac_update_dbstats(Oid dbid,                    TransactionId
vacuumXID,                   TransactionId frozenXID);
 


-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Michael Paesold
Date:
Subject: Re: Interval aggregate regression failure (expected seems
Next
From: Lars Kanis
Date:
Subject: Problems with index-scan on regexp in 8.1