Re: PL/Perl regression tests with use_strict - Mailing list pgsql-patches

From Michael Fuhr
Subject Re: PL/Perl regression tests with use_strict
Date
Msg-id 20050824053726.GA34097@winnie.fuhr.org
Whole thread Raw
In response to Re: PL/Perl regression tests with use_strict  (Michael Fuhr <mike@fuhr.org>)
Responses Re: PL/Perl regression tests with use_strict
List pgsql-patches
On Tue, Aug 23, 2005 at 10:30:51PM -0600, Michael Fuhr wrote:
> Global symbol "$x" requires explicit package name at (eval 3) line 1.
>
> If I'm reading the Perl source code correctly (pp_ctl.c), the number
> following "eval" comes from a variable named PL_evalseq that's
> incremented each time it appears in one of these messages.  It looks
> like we'd have to munge the error message to get rid of that.

Hmmm...tests suggest that we might be able to munge $@ in the
mk*safefunc functions.  That is, instead of doing

  return eval($stuff);

we might be able to do

  my $retval = eval($stuff);
  $@ =~ s/ \(eval \d+\) / /g if $@;
  return $retval;

That would convert messages like

  Global symbol "$x" requires explicit package name at (eval 3) line 1.

into

  Global symbol "$x" requires explicit package name at line 1.

Is that what you're looking for?  So far I've done only simple tests
in standalone embedded Perl programs, so I don't know if this approach
would work in PL/Perl or have unintended effects.

--
Michael Fuhr

pgsql-patches by date:

Previous
From: Michael Fuhr
Date:
Subject: Re: PL/Perl regression tests with use_strict
Next
From: "Andrew Dunstan"
Date:
Subject: Re: PL/Perl regression tests with use_strict