SVN Commit by andreas: r4411 - in trunk/pgadmin3/src: frm main - Mailing list pgadmin-hackers

From svn@pgadmin.org
Subject SVN Commit by andreas: r4411 - in trunk/pgadmin3/src: frm main
Date
Msg-id 200508211157.j7LBveTU007351@developer.pgadmin.org
Whole thread Raw
List pgadmin-hackers
Author: andreas
Date: 2005-08-21 12:57:39 +0100 (Sun, 21 Aug 2005)
New Revision: 4411

Modified:
   trunk/pgadmin3/src/frm/frmOptions.cpp
   trunk/pgadmin3/src/main/events.cpp
Log:
fix destructor error

Modified: trunk/pgadmin3/src/frm/frmOptions.cpp
===================================================================
--- trunk/pgadmin3/src/frm/frmOptions.cpp    2005-08-21 11:53:02 UTC (rev 4410)
+++ trunk/pgadmin3/src/frm/frmOptions.cpp    2005-08-21 11:57:39 UTC (rev 4411)
@@ -314,5 +314,5 @@
 {
     frmOptions *frm=new frmOptions(form);
     frm->Show();
-    return frm;
+    return 0;
 }

Modified: trunk/pgadmin3/src/main/events.cpp
===================================================================
--- trunk/pgadmin3/src/main/events.cpp    2005-08-21 11:53:02 UTC (rev 4410)
+++ trunk/pgadmin3/src/main/events.cpp    2005-08-21 11:57:39 UTC (rev 4411)
@@ -108,6 +108,11 @@
     while ((node=frames.GetFirst()) != NULL)
     {
         fr=node->GetData();
+
+        // if crashes occur here when closing the app,
+        // some actionFactory::StartDialog returned a wxWindow* (which is registered in frames)
+        // without code to handle OnClose (esp. removing itself with RemoveFrame)
+
         if (!fr->Close(!event.CanVeto()))
         {
             if (event.CanVeto())


pgadmin-hackers by date:

Previous
From: Tomasz Rybak
Date:
Subject: pgAdmin3 svn 4409 on Debian - segfault
Next
From: svn@pgadmin.org
Date:
Subject: SVN Commit by andreas: r4412 - trunk/pgadmin3/src/ui