Re: [HACKERS] For review: Server instrumentation patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] For review: Server instrumentation patch
Date
Msg-id 200508112001.j7BK1IE23143@candle.pha.pa.us
Whole thread Raw
List pgsql-patches
pgman wrote:
> Andreas Pflug wrote:
> > Bruce Momjian wrote:
> > > Dave Page wrote:
> > >
> > >
> > > The only part I didn't like about the patch is the stat display:
> > >
> > >     test=> select pg_file_stat('postgresql.conf');
> > >                                     pg_file_stat
> > >     -----------------------------------------------------------------------------
> > >
> > >      (12287,"2005-08-11 00:06:30","2005-08-11 00:06:43","2005-08-11 00:06:30",f)
> > >     (1 row)
> > >
> > > Shouldn't this return multiple labeled columns rather than an array?
> >
> > pg_show_all_settings output is equally unreadable, designed not to be
> > used directly.
>
> True, but we have SELECT * FROM pg_settings() that does display the
> titles.  Right now the values aren't even documented.

Sorry, I now see the return values are documented.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] For review: Server instrumentation patch
Next
From: Mark Wong
Date:
Subject: Re: [HACKERS] O_DIRECT for WAL writes