Re: Sun inline assembler ... - Mailing list pgsql-bugs

I have applied the following patch to fix this, hopefully.

---------------------------------------------------------------------------

John R Pierce wrote:
> Tom Lane wrote:
> >>>Here's what I see in REL8_0_STABLE
> >>>and in HEAD (s_lock.c 1.35):
> >>>
> >>>244 #ifdef SUNOS4_CC
> >>>245     asm(".seg \"data\"");
> >>>246     asm(".seg \"text\"");
> >>>247 #else
> >>>248     asm(".section \"data\"");
> >>>249     asm(".section \"text\"");
> >>>250 #endif
> >
> >
> > I see that template/sunos4 adds -DSUNOS4_CC to CFLAGS, but template/solaris
> > does not.  Maybe it should too?  I'm not real clear about which platforms
> > each of those templates gets used on.
>
> as a random reminder for those who don't deal with sun... Solaris is SunOS 5.x,
> currently 5.9 and now 5.10.  To get really confusing, they called it Solaris
> 2.x up to 2.6 (actually SunOS 5.7), then Solaris 7 was 2.7/5.7
>
>     solaris    ver    sunos ver
>     Solaris 1.3    SunOS 4.3
>     Solaris 2.5.1    SunOS 5.5.1
>     Solaris 2.6    SunOS 5.6
>     Solaris 7    SunOS 5.7
>     Solaris 8    SunOS 5.8
>     Solaris 9    SunOS 5.9
>
> this is nearly as bad as Java versioning.
>
>     Java 1.x
>     Java 2
>     Java 2.1
>     Java 2.1.1     -> Java2 release 1.1
>     Java 2.1.4.2     -> Java2 1.4.2
>     Java 2.5    -> J2SE 5.0
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo@postgresql.org so that your
>        message can get through to the mailing list cleanly
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/backend/storage/lmgr/s_lock.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/storage/lmgr/s_lock.c,v
retrieving revision 1.35
diff -c -c -r1.35 s_lock.c
*** src/backend/storage/lmgr/s_lock.c    31 Dec 2004 22:01:05 -0000    1.35
--- src/backend/storage/lmgr/s_lock.c    30 Jul 2005 03:03:20 -0000
***************
*** 241,247 ****
                                   * *lock); */
  {

! #ifdef SUNOS4_CC
      asm(".seg \"data\"");
      asm(".seg \"text\"");
  #else
--- 241,247 ----
                                   * *lock); */
  {

! #ifdef SUNOS_CC
      asm(".seg \"data\"");
      asm(".seg \"text\"");
  #else
Index: src/template/solaris
===================================================================
RCS file: /cvsroot/pgsql/src/template/solaris,v
retrieving revision 1.22
diff -c -c -r1.22 solaris
*** src/template/solaris    2 Dec 2004 18:11:40 -0000    1.22
--- src/template/solaris    30 Jul 2005 03:03:21 -0000
***************
*** 1,6 ****
  if test "$GCC" != yes ; then
    CC="$CC -Xa"            # relaxed ISO C mode
!   CFLAGS="-v"            # -v is like gcc -Wall
    if test "$enable_debug" != yes; then
      CFLAGS="$CFLAGS -O"        # any optimization breaks debug
    fi
--- 1,6 ----
  if test "$GCC" != yes ; then
    CC="$CC -Xa"            # relaxed ISO C mode
!   CFLAGS="-v -DSUNOS_CC" # -v is like gcc -Wall
    if test "$enable_debug" != yes; then
      CFLAGS="$CFLAGS -O"        # any optimization breaks debug
    fi
Index: src/template/sunos4
===================================================================
RCS file: /cvsroot/pgsql/src/template/sunos4,v
retrieving revision 1.4
diff -c -c -r1.4 sunos4
*** src/template/sunos4    29 Dec 2004 23:47:40 -0000    1.4
--- src/template/sunos4    30 Jul 2005 03:03:21 -0000
***************
*** 1,6 ****
  if test "$GCC" != yes ; then
    CC="$CC -Xa"            # relaxed ISO C mode
!   CFLAGS="-v -DSUNOS4_CC"    # -v is like gcc -Wall
    if test "$enable_debug" != yes; then
      CFLAGS="$CFLAGS -O"        # any optimization breaks debug
    fi
--- 1,6 ----
  if test "$GCC" != yes ; then
    CC="$CC -Xa"            # relaxed ISO C mode
!   CFLAGS="-v -DSUNOS_CC"    # -v is like gcc -Wall
    if test "$enable_debug" != yes; then
      CFLAGS="$CFLAGS -O"        # any optimization breaks debug
    fi