Re: pgsql: Add time/date macros for code clarity: #define - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Add time/date macros for code clarity: #define
Date
Msg-id 200507210518.j6L5IXB08330@candle.pha.pa.us
Whole thread Raw
In response to Re: pgsql: Add time/date macros for code clarity: #define DAYS_PER_YEAR  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Fixed.

---------------------------------------------------------------------------

Tom Lane wrote:
> BTW, the initial returns (see kookaburra buildfarm log) say that you
> broke things completely.
>
> cc -O2 -qmaxmem=16384 -qsrcmsg -qlonglong -g -I../../../../src/include -I/usr/local/include  -c -o timestamp.o
timestamp.c
>      1211 |         span->time = (((((tm->tm_hour * ((int64) SECS_PER_MINUTELL)) +
>             .................................................a....................
> a - 1506-045 (S) Undeclared identifier SECS_PER_MINUTELL.
>      1611 |         span1 += interval1->month * ((int64) DAYS_PER_MONTHLL) * ((int64) 86400000000LL);
>             .............................................a..................................
> a - 1506-045 (S) Undeclared identifier DAYS_PER_MONTHLL.
>      1612 |         span1 += interval1->day * ((int64) HOURS_PER_DAYLL) * ((int64) 3600000000LL);
>             ...........................................a....................................
> a - 1506-045 (S) Undeclared identifier HOURS_PER_DAYLL.
>      2267 |         result->time += (months - result->month) * ((int64) DAYS_PER_MONTHLL) * ((int64) 86400000000LL);
>             ............................................................a...................
> a - 1506-045 (S) Undeclared identifier DAYS_PER_MONTHLL.
>      2268 |         result->time += (days - result->day) * ((int64) HOURS_PER_DAYLL) * ((int64) 3600000000LL);
>             ........................................................a.......................
> a - 1506-045 (S) Undeclared identifier HOURS_PER_DAYLL.
> gmake[4]: *** [timestamp.o] Error 1
>
>
>             regards, tom lane
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Fix integer timestamp build for macro changes.
Next
From: applejack@pgfoundry.org (User Applejack)
Date:
Subject: uri - uri: added uri_table -> uri cast