pgcrypto: OpenSSL/DES cleanup - Mailing list pgsql-patches

From Marko Kreen
Subject pgcrypto: OpenSSL/DES cleanup
Date
Msg-id 20050707092553.GA8755@l-t.ee
Whole thread Raw
Responses Re: pgcrypto: OpenSSL/DES cleanup  (Michael Fuhr <mike@fuhr.org>)
Re: pgcrypto: OpenSSL/DES cleanup  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
As Kris Jurka found out, pgcrypto does not work with
OpenSSL 0.9.6x.  The DES functions use the older 'des_'
API, but the newer 3DES functions use the 0.9.7x-only
'DES_' API.

I think I just used /usr/include/openssl/des.h for reference
when implementing them, and had upgraded OpenSSL in the
meantime.

Following patch converts DES also to newer API and provides
compatibility functions for OpenSSL < 0.9.7.

I chose this route because:

- openssl.c uses few DES functions.
- compatibility for old 'des_' API is going away at some point
  of time from OpenSSL.
- as seen from macros, new API is saner
- Thus pgcrypto supports any OpenSSL version from 0.9.5 to 1.0

Tested with OpenSSL 0.9.6c and 0.9.7e.

--
marko

PS. It's nice to see that the 'autoconfiguration' already pays
back.


Attachment

pgsql-patches by date:

Previous
From: Koichi Suzuki
Date:
Subject: A couple of patches for PostgreSQL 64bit support
Next
From: Michael Fuhr
Date:
Subject: Re: pgcrypto: OpenSSL/DES cleanup