Re: #ifdef NOT_USED - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: #ifdef NOT_USED
Date
Msg-id 20050628072425.GA25909@penne.toroid.org
Whole thread Raw
In response to Re: #ifdef NOT_USED  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: #ifdef NOT_USED
List pgsql-hackers
(Sorry for the delayed response. I just got home from Germany after my
visit to Linuxtag, and I'm catching up with my -hackers email now.)

At 2005-06-25 09:30:17 -0400, pgman@candle.pha.pa.us wrote:
>
> > Hi, i have found several #ifdef NOT_USED marked code...
>
> We keep such blocks of code around in case we might need to use it
> some day.

I think that's a bad idea. Unused code should be removed with a suitable
CVS checkin comment (and perhaps a comment where the code was), not left
to clutter live code. That's what version control is for.

-- ams


pgsql-hackers by date:

Previous
From: "Dave Page"
Date:
Subject: Re: For review: dbsize patch
Next
From: Teodor Sigaev
Date:
Subject: Re: contrib/rtree_gist into core system?