Re: [HACKERS] Fix PID file location? - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Fix PID file location?
Date
Msg-id 200506041814.j54IEUK16349@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Fix PID file location?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Is reading postgresql.conf
> > from pg_ctl without a parser really accurate?
>
> The brute-force solution is to duplicate guc-file.l.
>
> That seems pretty ugly but in the long run it might be the most
> maintainable solution.  We eventually gave up trying to have a
> cut-rate SQL lexer in psql, and duplicated parser/scan.l.
> Might be best to just go for that solution up front in this case.

Added to TODO:

> * Allow pg_ctl to work properly with configuration files located outside
>   the PGDATA directory
>
>   pg_ctl can not read the pid file because it isn't located in the
>   config directory but in the PGDATA directory.  The solution is to
>   allow pg_ctl to read and understand postgresql.conf to find the
>   data_directory value.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: O_DIRECT for WAL writes
Next
From: Bruce Momjian
Date:
Subject: Re: Server instrumentation: pg_terminate_backend, pg_reload_conf