Re: DELETE ... USING - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: DELETE ... USING
Date
Msg-id 200504090406.j3946hJ14433@candle.pha.pa.us
Whole thread Raw
In response to Re: DELETE ... USING  (Neil Conway <neilc@samurai.com>)
Responses Re: DELETE ... USING
Re: DELETE ... USING
List pgsql-patches
Neil Conway wrote:
> Euler Taveira de Oliveira wrote:
> > Could you provide a patch?
>
> Sure, a revised patch is attached. Note that this change will also
> require updating 25 (!) of the regression tests, since they use the
> SELECT-without-FROM syntax. I will update the tests (by adding an
> explicit FROM clause) before applying the patch -- which I'll do
> tomorrow, barring any objections.

I just checked current CVS and see exactly what you describe:

    test=> SELECT pg_class.* LIMIT 0;
    ERROR:  missing FROM-clause entry for table "pg_class"

    test=> SET add_missing_from=true;
    SET
    test=> SELECT pg_class.* LIMIT 0;
    NOTICE:  adding missing FROM-clause entry for table "pg_class"

Is this what we want?  I don't think so.  I thought we wanted to
maintain the backward-compatible syntax of no FROM clause.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Adjust SGML ulink tags to the URL is always
Next
From: Neil Conway
Date:
Subject: Re: DELETE ... USING