Re: DELETE ... USING - Mailing list pgsql-patches

From Euler Taveira de Oliveira
Subject Re: DELETE ... USING
Date
Msg-id 20050406104534.53029.qmail@web54604.mail.yahoo.com
Whole thread Raw
In response to DELETE ... USING  (Neil Conway <neilc@samurai.com>)
Responses Re: DELETE ... USING  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Hi Neil,

> Looking at how to implement this, there is some rather dodgy code in
> warnAutoRange() in parse_relation.c that only emits the notice about
> adding a missing FROM clause entry if the query already has at least
> one
> range table entry in its FROM clause. The idea appears to be to not
> issue warnings about queries like "SELECT foo.*;", but it also means
> we
> don't end up warning about DELETE and UPDATE.
>
> I think the right fix is to remove the "inFromCl" check, and always
> issue a notice. With add_missing_from=true, all these queries are
> rejected anyway, so I think it makes sense to warn about all of them
> when add_missing_from is disabled. Objections?
>
No. That's why I'm thinking now while looking at the code :) Could you
provide a patch?


Euler Taveira de Oliveira
euler[at]yahoo_com_br





Yahoo! Acesso Grátis - Internet rápida e grátis.
Instale o discador agora! http://br.acesso.yahoo.com/

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: avg(int2) and avg(int8) micro-opt
Next
From: Neil Conway
Date:
Subject: Re: DELETE ... USING