Re: Savepoints and SPI - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Savepoints and SPI
Date
Msg-id 20050316201206.GA7907@dcc.uchile.cl
Whole thread Raw
In response to Savepoints and SPI  (Thomas Hallgren <thhal@mailblocks.com>)
Responses Re: Savepoints and SPI  (Thomas Hallgren <thhal@mailblocks.com>)
List pgsql-hackers
On Wed, Mar 16, 2005 at 07:35:57PM +0100, Thomas Hallgren wrote:
> I have some test code that utilize SPI and does the following:
> 
> 1. SPI_connect
> 2. set a savepoint (using BeginInternalSubTransaction)
> 3. execute a statement that contains a syntax error (within PG_TRY/PG_CATCH)
> 4. rollback to the savepoint (RollbackAndReleaseCurrentSubTransaction)
> 5. execute some other statement.
> 
> it errors out in step 5 with SPI_ERROR_UNCONNECTED. It seems that step 
> 3, when it encounters an error, automatically executes a SPI_finish. Is 
> that the desired behavior?

I'd expect the code to close an SPI connection that is opened inside the
savepoint, but if you open it before setting the savepoint then it
should remain open.

-- 
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
"Endurecerse, pero jamás perder la ternura" (E. Guevara)


pgsql-hackers by date:

Previous
From: Thomas Hallgren
Date:
Subject: Savepoints and SPI
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] [pgsql-hackers-win32] snprintf causes regression