Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Code review for recent libpq changes. - Mailing list pgsql-committers

From Michael Fuhr
Subject Re: pgsql: Code review for recent libpq changes.
Date
Msg-id 20041203015329.GB5451@winnie.fuhr.org
Whole thread Raw
In response to pgsql: Code review for recent libpq changes.  (tgl@svr1.postgresql.org (Tom Lane))
Responses Re: pgsql: Code review for recent libpq changes.
List pgsql-committers
Tree view 
On Thu, Dec 02, 2004 at 11:20:24PM +0000, Tom Lane wrote:

> Code review for recent libpq changes.  Be more careful about error
> handling in SIGPIPE processing; avoid unnecessary pollution of application
> link-symbol namespace; spell 'pointer to function' in the conventional
> way.

Build failure on FreeBSD 4.10-STABLE:

fe-secure.c: In function `pqsecure_write':
fe-secure.c:433: `got_epipe' undeclared (first use in this function)

got_epipe is declared in an #ifdef ENABLE_THREAD_SAFETY block but
then used outside of such a block.

--
Michael Fuhr
http://www.fuhr.org/~mfuhr/

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix for Unicode characters above 0x10000.
Next
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Fix compile breakage from SIGPIPE fix for threading.