Re: [HACKERS] Open Items - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Open Items
Date
Msg-id 200411121759.iACHxRV18935@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Open Items  ("Zeugswetter Andreas DAZ SD" <ZeugswetterA@spardat.at>)
List pgsql-patches
Zeugswetter Andreas DAZ SD wrote:
> I think in addition the system global name "sharemem.1" should be made more
> pg specific, like "PostgreSQL.1". I have not done this since a new compile
> would not detect a running old beta. But now would be the time (or never).

Change made and attached.  I assume there are other ways we detect an
active backend on Windows and that shared memory name is only one of
them.  I do think we need this fix before we put out a final release so
the next beta is the best time to do it.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/backend/port/win32/shmem.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/port/win32/shmem.c,v
retrieving revision 1.8
diff -c -c -r1.8 shmem.c
*** src/backend/port/win32/shmem.c    29 Aug 2004 05:06:46 -0000    1.8
--- src/backend/port/win32/shmem.c    12 Nov 2004 16:53:28 -0000
***************
*** 89,95 ****
      DWORD        dwRet;

      s_segsize = size;
!     sprintf(szShareMem, "sharemem.%d", memKey);

      if (flag & IPC_CREAT)
      {
--- 89,95 ----
      DWORD        dwRet;

      s_segsize = size;
!     sprintf(szShareMem, "PostgreSQL.%d", memKey);

      if (flag & IPC_CREAT)
      {

pgsql-patches by date:

Previous
From: Gavin Sherry
Date:
Subject: PITR docs enhancements
Next
From: "Magnus Hagander"
Date:
Subject: Win32 signals & sockets