pgsql: That's just the lovely way windows handles a "segfault". - Mailing list pgsql-committers

From momjian@svr1.postgresql.org (Bruce Momjian)
Subject pgsql: That's just the lovely way windows handles a "segfault".
Date
Msg-id 20041101192217.B91C63A3CBB@svr1.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
That's just the lovely way windows handles a "segfault". Gotta be really
interesting for MS to catch all those dumps...

Anyway. Oops. Seems I ran my regression tests with the old psql, and
just managed to update the backend, when I tested that patch. Turns out
there are codepaths where we'd access the Critical Section before it was
initialized. Attached patch breaks the initializeation off to a separate
part and adds that one to a much earlier position in the program.

Magnus Hagander

Modified Files:
--------------
    pgsql/src/bin/psql:
        common.c (r1.93 -> r1.94)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/common.c.diff?r1=1.93&r2=1.94)
        common.h (r1.40 -> r1.41)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/common.h.diff?r1=1.40&r2=1.41)
        startup.c (r1.104 -> r1.105)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/startup.c.diff?r1=1.104&r2=1.105)

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Clarify coding of .exe patch
Next
From: dpage@pgfoundry.org (User Dpage)
Date:
Subject: pginstaller - pginst: Write the bindir path for pgAdmin to pick up.