Reini Urban wrote:
> Magnus Hagander schrieb:
> >>beta4 - cygwin:
> >>postgres.exe fails to build, because __imp__my_exec_path from
> >>src/timezone/pgtz.o cannot be resolved. previously it was not
> >>imported.
> >
> > This could be related to the patch that went in last weekend to fix
> > compiles on Win32. DLLIMPORT was added to the header. If the Makefile
> > did not change, then that is your problem - that patch changed botht he
> > makefile and the header. See
> > http://archives.postgresql.org/pgsql-committers/2004-10/msg00321.php
> >
> > Does CYGWIN perhaps need the same Makefile patch?
>
> You only patched your Makefile.win32, not Makefile.cygwin. That's it. It
> builds fine now.
>
> Please add also
>
> ifneq (,$(findstring timezone,$(subdir)))
> override CPPFLAGS+= -DBUILDING_DLL
> endif
>
OK, patch applied. I also fixed the ecpg test in Makefile.win32.
> to the Makefile.cygwin.
> Without it doesn't break just contrib/tsearch, it even breaks cygwin
> postmaster.
>
> Maybe all win32.mak and bcc32.mak must also be checked. Does anybody do
> the msvc/borland suites?
Those don't build the backend, only libpq and psql.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Index: src/makefiles/Makefile.cygwin
===================================================================
RCS file: /cvsroot/pgsql/src/makefiles/Makefile.cygwin,v
retrieving revision 1.4
diff -c -c -r1.4 Makefile.cygwin
*** src/makefiles/Makefile.cygwin 19 Jan 2004 21:20:06 -0000 1.4
--- src/makefiles/Makefile.cygwin 27 Oct 2004 19:12:29 -0000
***************
*** 23,28 ****
--- 23,32 ----
endif
endif
+ ifneq (,$(findstring timezone,$(subdir)))
+ override CPPFLAGS+= -DBUILDING_DLL
+ endif
+
ifneq (,$(findstring ecpg/ecpglib,$(subdir)))
override CPPFLAGS+= -DBUILDING_DLL
endif
Index: src/makefiles/Makefile.win32
===================================================================
RCS file: /cvsroot/pgsql/src/makefiles/Makefile.win32,v
retrieving revision 1.4
diff -c -c -r1.4 Makefile.win32
*** src/makefiles/Makefile.win32 22 Oct 2004 22:33:58 -0000 1.4
--- src/makefiles/Makefile.win32 27 Oct 2004 19:12:29 -0000
***************
*** 27,33 ****
override CPPFLAGS+= -DBUILDING_DLL
endif
! ifneq (,$(findstring ecpg/lib,$(subdir)))
override CPPFLAGS+= -DBUILDING_DLL
endif
--- 27,33 ----
override CPPFLAGS+= -DBUILDING_DLL
endif
! ifneq (,$(findstring ecpg/ecpglib,$(subdir)))
override CPPFLAGS+= -DBUILDING_DLL
endif
