Re: pg_restore - added documentation - Mailing list pgsql-patches

OK, wording updated and applied.  I used "process" instead of "issue".

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > However, I wonder if "output database" is the proper name for -d?
> > Isn't it more "restore database" or "target database"?
>
> "restore database name" sounds like, "When this option is specified,
> only the database name is restored.".  "target database" sounds a lot
> better.
>
> Your other change, "issue commands" may be interpreted incorrectly.
> When not restoring to a database, the commands are in fact "output",
> not "issued".  Not sure how to make that clear, though I don't much
> like "issue" either way, because it doesn't have a precise meaning.
>
> --
> Peter Eisentraut
> http://developer.postgresql.org/~petere/
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/bin/pg_dump/pg_restore.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/pg_dump/pg_restore.c,v
retrieving revision 1.63
diff -c -c -r1.63 pg_restore.c
*** src/bin/pg_dump/pg_restore.c    13 Oct 2004 00:42:53 -0000    1.63
--- src/bin/pg_dump/pg_restore.c    13 Oct 2004 14:23:37 -0000
***************
*** 360,366 ****
      printf(_("  %s [OPTION]... [FILE]\n"), progname);

      printf(_("\nGeneral options:\n"));
!     printf(_("  -d, --dbname=NAME        restore database name\n"));
      printf(_("  -f, --file=FILENAME      output file name\n"));
      printf(_("  -F, --format=c|t         specify backup file format\n"));
      printf(_("  -i, --ignore-version     proceed even when server version mismatches\n"));
--- 360,366 ----
      printf(_("  %s [OPTION]... [FILE]\n"), progname);

      printf(_("\nGeneral options:\n"));
!     printf(_("  -d, --dbname=NAME        target database name\n"));
      printf(_("  -f, --file=FILENAME      output file name\n"));
      printf(_("  -F, --format=c|t         specify backup file format\n"));
      printf(_("  -i, --ignore-version     proceed even when server version mismatches\n"));
***************
*** 372,378 ****
      printf(_("\nOptions controlling the restore:\n"));
      printf(_("  -a, --data-only          restore only the data, no schema\n"));
      printf(_("  -c, --clean              clean (drop) schema prior to create\n"));
!     printf(_("  -C, --create             issue commands to create the database\n"));
      printf(_("  -I, --index=NAME         restore named index\n"));
      printf(_("  -L, --use-list=FILENAME  use specified table of contents for ordering\n"
               "                           output from this file\n"));
--- 372,378 ----
      printf(_("\nOptions controlling the restore:\n"));
      printf(_("  -a, --data-only          restore only the data, no schema\n"));
      printf(_("  -c, --clean              clean (drop) schema prior to create\n"));
!     printf(_("  -C, --create             process commands to create the database\n"));
      printf(_("  -I, --index=NAME         restore named index\n"));
      printf(_("  -L, --use-list=FILENAME  use specified table of contents for ordering\n"
               "                           output from this file\n"));