Re: Preliminary patch for FRONTEND - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Preliminary patch for FRONTEND
Date
Msg-id 200410011222.i91CMKA21859@candle.pha.pa.us
Whole thread Raw
In response to Re: Preliminary patch for FRONTEND  (Neil Conway <neilc@samurai.com>)
Responses Re: Preliminary patch for FRONTEND  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Neil Conway wrote:
> Pasto:
>
> *** src/bin/pg_config/Makefile  1 Aug 2004 06:56:38 -0000       1.8
> --- src/bin/pg_config/Makefile  1 Oct 2004 04:04:06 -0000
> ***************
> *** 1,18 ****
> [...]
> --- 1,23 ----
> !
> #-------------------------------------------------------------------------
> ! #
> ! # Makefile for src/bin/pg_controldata
> ! #
> ! # Copyright (c) 1998-2002, PostgreSQL Global Development Group
> ! #
> ! # $PostgreSQL: pgsql-server/src/bin/pg_controldata/Makefile,v 1.9
> 2004/05/26 17:24:01 tgl Exp $
> ! #
> !
> #-------------------------------------------------------------------------
>
> s/pg_controldata/pg_config/ (and maybe fix the copyright date range?)
>
> *** src/port/Makefile   28 Aug 2004 22:55:06 -0000      1.18
> --- src/port/Makefile   1 Oct 2004 04:04:11 -0000
> ***************
> *** 48,51 ****
>         echo "#define LOCALEDIR \"$(localedir)\"" >>$@
>
>   clean distclean maintainer-clean:
> !       rm -f libpgport.a $(LIBOBJS) pg_config_paths.h
> --- 68,71 ----
>         echo "#define LOCALEDIR \"$(localedir)\"" >>$@
>
>   clean distclean maintainer-clean:
> !       rm -f libpgport.a $(LIBOBJS) $(LIBOBJS_SRV) pg_config_paths.h
>
> "clean" should remove libpgport_srv.a as well, shouldn't it?

Fixed, thanks.

> *** src/port/getaddrinfo.c      28 Sep 2004 00:07:01 -0000      1.15
> --- src/port/getaddrinfo.c      1 Oct 2004 04:04:12 -0000
> ***************
> *** 26,31 ****
> --- 26,32 ----
>   #include <netdb.h>
>   #include <netinet/in.h>
>   #include <arpa/inet.h>
> + #include <rpc/types.h>
>   #endif
>
>   #include "getaddrinfo.h"
>
> What is this change for?

My OS couldn't compile getaddrinfo when I tried, though my OS doesn't
need getaddrinfo so maybe we shouldn't make that change. Comments?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Preliminary patch for FRONTEND
Next
From: "Dave Page"
Date:
Subject: Int_aggregate/pgstattuple minor fix