Looks good. I will have to do a little adjustment because dirmod is
currently only used by Win32.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
>
> >Andrew Dunstan wrote:
> >
> >
> >>>I wanted to keep a solution that was as native to the OS as possible,
> >>>but because we can't do that on Win32 and few people like the unix
> >>>system call to 'rm', it is time to clean it up.
> >>>
> >>>One question --- why is there a sleep loop needed for unlink in your
> >>>patch?
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>We will just be calling the existing pgunlink() (which has a sleep) in
> >>the Windows cases, so this question becomes moot.
> >>
> >>
> >
> >Great. Thanks. Sorry I delayed addressing this for so long.
> >
> >
>
> Please check the enclosed patch to see if it does what you want.
>
> >Should we look at replacing cp/copy in 7.6?
> >
> >
> >
>
> probably. Put it as a possible TODO maybe.
>
> cheers
>
> andrew
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
