Re: Borland c++ compile problems... - Mailing list pgsql-hackers-win32

From Bruce Momjian
Subject Re: Borland c++ compile problems...
Date
Msg-id 200407210308.i6L389J13710@candle.pha.pa.us
Whole thread Raw
In response to Borland c++ compile problems...  (Steve Holdoway <steve@treshna.com>)
Responses Re: Borland c++ compile problems...
List pgsql-hackers-win32
OK, patch attached that fixes it.  Should that define just check for GCC
instead of checking if the compiler isn't MS or Borland?

---------------------------------------------------------------------------

Steve Holdoway wrote:
> Hi folks,
> 
> It seems that Borland C++ ( I'm using the command line version 5.5 ) 
> takes exception to #defines like the following...
> 
> #define open(a, b...) win32_open ( a, b, ##__VA_ARGS__ )
>   [ to be found in port.h on the current development snapshot ]
> 
> This causes compilation to fail. I'm after a version of blibpq.dll that 
> supports ssl connections, and the one I compiled previously ( 7.4.2 I 
> think ) doesn't seem to.
> 
> Can anyone suggest a solution. I speak C fluently... it's this pesky 
> windows stuff that causes me grief!
> 
> Cheers,
> 
> Steve
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/include/port.h
===================================================================
RCS file: /cvsroot/pgsql-server/src/include/port.h,v
retrieving revision 1.43
diff -c -c -r1.43 port.h
*** src/include/port.h    11 Jun 2004 16:10:09 -0000    1.43
--- src/include/port.h    21 Jul 2004 03:01:33 -0000
***************
*** 151,157 ****
  #ifdef WIN32
  
  /* open() replacement to allow delete of held files */
! #ifndef _MSC_VER
  extern int    win32_open(const char*,int,...);
  #define     open(a,b,...)    win32_open(a,b,##__VA_ARGS__)
  #endif
--- 151,157 ----
  #ifdef WIN32
  
  /* open() replacement to allow delete of held files */
! #if !defined(_MSC_VER) && !defined(__BORLANDC__)
  extern int    win32_open(const char*,int,...);
  #define     open(a,b,...)    win32_open(a,b,##__VA_ARGS__)
  #endif

pgsql-hackers-win32 by date:

Previous
From: Steve Holdoway
Date:
Subject: Borland c++ compile problems...
Next
From: chips42
Date:
Subject: FAT or NTFS on W2k