Re: SysLogger subprocess - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: SysLogger subprocess
Date
Msg-id 20040715193604.GA3393@dcc.uchile.cl
Whole thread Raw
In response to SysLogger subprocess  (Andreas Pflug <pgadmin@pse-consulting.de>)
Responses Re: SysLogger subprocess  (Andreas Pflug <pgadmin@pse-consulting.de>)
List pgsql-hackers
On Thu, Jul 15, 2004 at 09:00:50PM +0200, Andreas Pflug wrote:

> While looking at pgstat.c to see how to peek for pipe data, I found
>     readpipe=pgStatPipe[0];
>     select(readPipe+1, ..);
> 
> which is probably usually the same as select(pgStatPipe[1], ..) This fd 
> arithmetics seem a bit dubious to me.

No, it's not pgStatPipe[1], it's select(2)'s first argument; max fd in
the sets plus one.  Probably your code works because
pgStatPipe[1] == pgStatPipe[0] + 1.

-- 
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Por suerte hoy explotó el califont porque si no me habría muerto
de aburrido"  (Papelucho)



pgsql-hackers by date:

Previous
From: Robert Treat
Date:
Subject: Re: possibly updating techdocs; mysql2pgsql on gborg
Next
From: Andreas Pflug
Date:
Subject: Re: SysLogger subprocess