Re: eventlog fix - Mailing list pgsql-patches

OK, I have created the following diff to document the pgevent
installation instructions.  However, you didn't send me a Makefile for
creating the DLL, and I am not sure how to do that.  Would you send me a
`Makefile for src/bin/pgevent?  Thanks.

---------------------------------------------------------------------------

Laurent Ballester wrote:
> Hello,
>
> >
> > We don't use this hungarian notation anywhere ... it certainly looks
> > ugly.
> >
>
> Sorry, I modify pgevent.c again and suppress all hungarian variables naming.
>
> I add a diff -c for src/bin/Makefile, necessary to compile pgevent for
> windows platform.
>
>
> regards
>
> Laurent Ballester

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: doc/src/sgml/installation.sgml
===================================================================
RCS file: /cvsroot/pgsql-server/doc/src/sgml/installation.sgml,v
retrieving revision 1.202
diff -c -c -r1.202 installation.sgml
*** doc/src/sgml/installation.sgml    23 May 2004 15:13:43 -0000    1.202
--- doc/src/sgml/installation.sgml    19 Jun 2004 05:12:09 -0000
***************
*** 1073,1078 ****
--- 1073,1091 ----
    </procedure>

    <formalpara>
+    <title>Registering <application>eventlog</> on <systemitem
+    class="osname">Windows</>:</title>
+    <para>
+     To register a <systemitem class="osname">Windows</> <application>eventlog</>
+     library with the operating system, issue this command after installation:
+ <screen>
+ <userinput>regsvr32 <replaceable>pgsql_library_directory</>/pgevent.dll</>
+ </screen>
+     This creates registry entries used by the event viewer.
+    </para>
+   </formalpara>
+
+   <formalpara>
     <title>Uninstallation:</title>
     <para>
      To undo the installation use the command <command>gmake
Index: src/bin/Makefile
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/Makefile,v
retrieving revision 1.44
diff -c -c -r1.44 Makefile
*** src/bin/Makefile    18 Jun 2004 21:24:05 -0000    1.44
--- src/bin/Makefile    19 Jun 2004 05:12:11 -0000
***************
*** 15,20 ****
--- 15,23 ----

  DIRS := initdb ipcclean pg_ctl pg_dump \
      psql scripts pg_config pg_controldata pg_resetxlog
+ ifeq ($(PORTNAME), win32)
+ DIRS+=pgevent
+ endif

  all install installdirs uninstall depend distprep:
      @for dir in $(DIRS); do $(MAKE) -C $$dir $@ || exit; done