Converting postgresql.conf parameters to kilobytes - Mailing list pgsql-hackers

From Shridhar Daithankar
Subject Converting postgresql.conf parameters to kilobytes
Date
Msg-id 200405301820.22873.shridhar@frodo.hserus.net
Whole thread Raw
Responses Re: Converting postgresql.conf parameters to kilobytes  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Converting postgresql.conf parameters to kilobytes  (pgsql@mohawksoft.com)
List pgsql-hackers
Hi,

I was toying around with idea of converting all the memory related parameters 
in postgresql.conf to kilobytes for simplicity and uniformity.

Attached is a proof of concept patch that converts shared_buffers to kilobytes 
using assign_hook.

It compiled all-right but I experienced a strange behavior. At the time of 
initdb, it demanded 69MB of shared memory. I had to bump up SHMMAX from 32MB 
to 128MB to get initdb through. Certainly I did something wrong somewhere but 
I don't know what and where. This is linux 2.6.4.

The postgresql.conf is properly altered and shows 8000(Though the description 
around is no longer in sync.)

I also don't know where to put the assign_hook. I have put in guc.c for the 
time being. Only other int hook I found was assign_max_stack_depth which is 
in postgres.c

Any comments/pointers?

Regards,Shridhar

pgsql-hackers by date:

Previous
From: Stephan Szabo
Date:
Subject: Re: Nested xacts: looking for testers and review
Next
From: Shridhar Daithankar
Date:
Subject: CVS tip compiler error with --enable-thread-safety