Re: Relocatable installs - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Relocatable installs
Date
Msg-id 200405082330.i48NUdD07121@candle.pha.pa.us
Whole thread Raw
In response to Re: Relocatable installs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Ah, got it.  Makes sense.  We do searches for finding our own path, but
> > you can argue that this predictable --- we know we are running so the
> > binary must be somewhere.  :-)  However, the version checking we do now
> > is a little non-predictable because if we find a binary of the wrong
> > version, we keep looking in the path.
> 
> Hm?  I see no version checks in FindExec.  It looks to me like the code
> is just trying to ensure that it finds the same file that the shell
> would have found.

I thought it was in ValidateBinary, but now I don't see it.  I must have
gotten it confused by pg_dumpall.  And I see now that initdb only checks
the version and exits if it is wrong.  It does not keep trying the path.

OK, we are better than I thought.  :-)

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Relocatable installs
Next
From: Christopher Kings-Lynne
Date:
Subject: Re: Comments on all system objects