Re: Win32 regression test status - Mailing list pgsql-hackers-win32

From Bruce Momjian
Subject Re: Win32 regression test status
Date
Msg-id 200403081921.i28JL4118502@candle.pha.pa.us
Whole thread Raw
In response to Re: Win32 regression test status  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Win32 regression test status  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers-win32
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Uh, I think you just add ORDER BY to the query and see if the output now
> > matches the regression test.  If so, submit a patch to add the ORDER BY.
>
> I'd really prefer not to add ORDER BY to all the join tests, as that
> would restrict the set of join plan types being tested.

Agreed, we don't add them to all joins, but don't we historically add
ORDER BY to queries that are shown to be sensitive to qsort
implementations on various platforms?  Are you suggesting we create a
separate regression output file for that platform?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-hackers-win32 by date:

Previous
From: Tom Lane
Date:
Subject: Re: Win32 regression test status
Next
From: Tom Lane
Date:
Subject: Re: Win32 regression test status