pg_ctl "starting" postmaster - Mailing list pgsql-patches

From Bruce Momjian
Subject pg_ctl "starting" postmaster
Date
Msg-id 200401100255.i0A2t5217338@candle.pha.pa.us
Whole thread Raw
List pgsql-patches
When pg_ctl is used to start the postmaster without the -w flag, it says

    postmaster successfully started

when in fact it should be "postmaster starting" because it hasn't
"started" yet, or at least isn't accepting connections yet.  A wait for
start says:

    waiting for postmaster to start...done
    postmaster successfully started

which is accurate.

This applied patch makes that adjustment and a similar one for stop.
Someone complained about this a few months ago.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/bin/pg_ctl/pg_ctl.sh
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/pg_ctl/pg_ctl.sh,v
retrieving revision 1.37
diff -c -c -r1.37 pg_ctl.sh
*** src/bin/pg_ctl/pg_ctl.sh    29 Nov 2003 19:52:04 -0000    1.37
--- src/bin/pg_ctl/pg_ctl.sh    10 Jan 2004 02:53:35 -0000
***************
*** 299,305 ****
      if [ "$op" = "reload" ];then
          $silence_echo echo "postmaster successfully signaled"
      else
!         $silence_echo echo "postmaster successfully shut down"
      fi

      else # ! -f $PIDFILE
--- 299,309 ----
      if [ "$op" = "reload" ];then
          $silence_echo echo "postmaster successfully signaled"
      else
!         if [ "$wait" = yes ];then
!         $silence_echo echo "postmaster successfully shut down"
!         else
!         $silence_echo echo "postmaster shutting down"
!         fi
      fi

      else # ! -f $PIDFILE
***************
*** 399,406 ****
          fi
      done
      $silence_echo echo "done"
      fi
-     $silence_echo echo "postmaster successfully started"
  fi # start or restart

  exit 0
--- 403,412 ----
          fi
      done
      $silence_echo echo "done"
+     $silence_echo echo "postmaster successfully started"
+     else
+     $silence_echo echo "postmaster starting"
      fi
  fi # start or restart

  exit 0

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: BEGIN WORK and transaction isolation level
Next
From: Claudio Natoli
Date:
Subject: Win32 processCancelRequest/waitpid (was fork/exec patch : pre-CreateProcess finalization)