Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for - Mailing list pgsql-bugs

From Bruce Momjian
Subject Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for
Date
Msg-id 200401030153.i031rdf08090@candle.pha.pa.us
Whole thread Raw
In response to Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for HP-UX  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Tom Lane wrote:
> It appears that there was once provision to do more interesting things
> via cpp: the Makefile and genbki shell script contain provisions to
> pass additional switches to cpp, which presumably might be used to
> insert "-D" switches so that identifiers could be expanded to something
> else in the BKI data.  But we aren't using that, and have not done so
> for a very long time.  Instead we expect genbki.sh itself to replace
> everything that needs replacing (NAMEDATALEN etc).  I see no reason
> why we'd abandon that technique in favor of using cpp again.
>
> So I propose that we remove the cpp invocation and associated
> infrastructure from genbki.sh.  Any objections?

I was wondering why the quote merging was happening only for *.c file in
HP's cpp.  And if it is legal for *.c, why not for *.h, and why doesn't
it hit us with other compilers.

Looks like we are not using awk for all the subsitutions.  Removing the
cpp call seems like a great idea.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for HP-UX
Next
From: Oliver Elphick
Date:
Subject: Re: Spinlock support for linux-hppa?