Re: \xDD patch for 7.5devel - Mailing list pgsql-hackers

From Jason Godden
Subject Re: \xDD patch for 7.5devel
Date
Msg-id 200311060743.07987.jasongodden@optushome.com.au
Whole thread Raw
In response to Re: \xDD patch for 7.5devel  (Markus Bertheau <twanger@bluetwanger.de>)
Responses Re: \xDD patch for 7.5devel
Re: \xDD patch for 7.5devel
List pgsql-hackers
On Thu, 6 Nov 2003 06:25 am, Markus Bertheau wrote:
> В Срд, 05.11.2003, в 16:25, Tom Lane пишет:
> > > +#define HEXVALUE(c) (((c)>='a') ? ((c)-87) : (((c)>='A') ? ((c)-55) :
> > > ((c)-'0')))
> >
> > This seems excessively dependent on the assumption that the character
> > set is ASCII.  Why have you hard-coded numeric equivalents into this
> > macro?
>
> What not ASCII compatible character sets are out there in use still
> today?

Ah, yes - didn't even think about the character sets.  If thats the case then
octal needs attention as well because it makes a similar assumption.  Peter
Eisentraut commented that this should be in the string literal parser.
Should this be the case? and if so should i migrate both octal and hex to
this parser?

Rgds,

Jason



pgsql-hackers by date:

Previous
From: Chris Bowlby
Date:
Subject: Schema boggle...
Next
From: Larry Rosenman
Date:
Subject: Re: \xDD patch for 7.5devel