Re: fix for strict-alias warnings - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: fix for strict-alias warnings
Date
Msg-id 200310130017.h9D0Hkn04642@candle.pha.pa.us
Whole thread Raw
In response to Re: fix for strict-alias warnings  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian wrote:
> Andrew Dunstan wrote:
> >
> > ----- Original Message -----
> > From: "Bruce Momjian" <pgman@candle.pha.pa.us>
> > >
> > > I have backed out the patch.
> > >
> > > Looking at the case in tablecmds.c and proc.c, the first was assigning a
> > > struct with a NodeTag pointer as its first element to another struct
> > > with NodeTag as its first element.  In fact, we do this all over the
> > > place, having different structure pointers with a start element of
> > > NodeTag.
>
> I have attached and applied the following patch to use makeNode for
> structures that will later be cast to Node*, rather than having them be
> allocated as stack variables.

Oh, and thanks to everyone for doing the research on this compiler issue.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: fix for strict-alias warnings
Next
From: "Andrew Dunstan"
Date:
Subject: Re: fix for strict-alias warnings