Re: fix log_min_duration_statement logic error - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: fix log_min_duration_statement logic error
Date
Msg-id 200310051317.h95DHPl14197@candle.pha.pa.us
Whole thread Raw
In response to Re: fix log_min_duration_statement logic error  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: fix log_min_duration_statement logic error  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Peter Eisentraut wrote:
> Tom Lane writes:
>
> > Sure it can.  You're essentially arguing that DBAs are too dumb to match
> > up matching query and duration log outputs.  I don't buy that.  I think
> > they'll be analyzing their logs with little Perl scripts anyway, and
> > that consistency of log output format will be worth more to those
> > scripts than sometimes having related items all on one log line.
>
> When you're dealing with a large installation, these little Perl scripts
> become difficult.  I've just had to deal with a similar issue with a
> popular MTA which spreads the relevant log information over several lines.
> If you're generating 500 MB of log output a day, it becomes a problem.

I can imagine.  I wasn't sure how I would write Perl code to join things
via pid.  I am sure it can be done (load into hash), but it wasn't
trivial like grep.

Peter, any problems with pid wrap-around?  I am thinking we need to
prepend a "wrap count" on the front of the pid output for 7.5.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: fix log_min_duration_statement logic error
Next
From: Bruce Momjian
Date:
Subject: Re: fix log_min_duration_statement logic error