Re: WIN32_CONSOLE usage - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: WIN32_CONSOLE usage
Date
Msg-id 200309071634.h87GY2P11147@candle.pha.pa.us
Whole thread Raw
In response to Re: WIN32_CONSOLE usage  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: WIN32_CONSOLE usage
List pgsql-patches
Peter Eisentraut wrote:

>   c) Problem:  8bit characters were displayed/interpreted wrong in psql
>                This is due to the fact that the Win32 "console" uses a
>                different encoding than the rest of the Windows system
>      Solution: Introduced a new psql variable WIN32_CONSOLE
>                When set with "\set WIN32_console", the function OemToChar()

> Bruce Momjian writes:
>
> > Is this a valid feature?  Should I document it?
>
> Maybe it's a valid feature, but the implementation is not valid.
> Other applications also make use of the print routines (e.g., createlang),
> and they cannot interactively set variables.  So I repeat: the print
> routines may not access the psql settings.
>
> I think we ought to detect the console type automatically anyway.
> Certainly we don't want people to have to set this variables all the time.

Agreed.  Automatic is ideal.  Any ideas out there?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: MinGW patch
Next
From: Bruce Momjian
Date:
Subject: Re: MinGW patch