Re: SetVariable - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: SetVariable
Date
Msg-id 200308301358.h7UDwu427952@candle.pha.pa.us
Whole thread Raw
In response to Re: SetVariable  ("Gaetano Mendola" <mendola@bigfoot.com>)
Responses Re: SetVariable
List pgsql-hackers
Gaetano Mendola wrote:
> "Bruce Momjian" <pgman@candle.pha.pa.us> wrote:
> > I see other strdup() calls that don't check on a return.  Should we deal
> > with those too?
> 
> Well strdup obtain the memory for the new string using a malloc
> and normally is a good habit check the return value of a malloc.

Right.  My point is that we have lots of other strdup's in the code. 
Should we fix those too?  Seems we should be consistent.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: "Gaetano Mendola"
Date:
Subject: Re: SetVariable
Next
From: Bruce Momjian
Date:
Subject: Re: Linux2.6 overcommit behaviour