Re: OSF build fixed - Mailing list pgsql-hackers

From Kurt Roeckx
Subject Re: OSF build fixed
Date
Msg-id 20030715201438.GA3884@ping.be
Whole thread Raw
In response to Re: OSF build fixed  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: OSF build fixed  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Jul 15, 2003 at 01:56:55PM -0400, Tom Lane wrote:
> Philip Yarra <philip@utiba.com> writes:
> > int64-pqcomm.patch: changes int64_t to int64 in src/include/libpq/pqcomm.h
> > tested on RedHat Linux 7.3 and OSF
> 
> Applied (along with some further hacking to make the struct padding
> logic more robust).

I'm not sure what you did exactly, or why you think it's better.
But it seems you removed the "6 byte pad", between the
ss_family and the __ss_align, and I have no idea why.

I won't say that I fully understand allignment as is defined in
the C standard(s), but I do know that it doesn't have to allign
an int64 to a multiple of 8 byte address.

Note that I didn't just make that structure up, other people did.
It's for instance like that in the RFC and in SUS v3.


Kurt



pgsql-hackers by date:

Previous
From: ivan
Date:
Subject: perm question
Next
From: Andrew Sullivan
Date:
Subject: Criteria for contrib/ versus gborg?