Re: log_min_duration_statement feature - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: log_min_duration_statement feature
Date
Msg-id 200304230231.h3N2VQ318678@candle.pha.pa.us
Whole thread Raw
In response to Re: log_min_duration_statement feature  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
List pgsql-patches
Christopher Kings-Lynne wrote:
> > Yes.  Consider declaring the "max value" in the GUC variable's info block
> > as INT_MAX/1000 instead of INT_MAX.
> >
> > (We should go through all of the GUC variables with an eye to places
> > where the max value is unrealistically high, but for the moment I'll
> > settle for not introducing any new sillinesses ...)
>
> OK, actually would it make more sense to just make it so that the duration
> threshold is given in microseconds instead of milliseconds?  Then I wouldn't
> have to multiply and people can threshold lower as well...?

As I remember all our other timings are in milliseconds so unless there
is a good reason, we should be consistent.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073


pgsql-patches by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: Re: log_min_duration_statement feature
Next
From: "Christopher Kings-Lynne"
Date:
Subject: log_min_duration_statement #2