Re: Require Assistance Solving Problem - erroneous pg_hba.conf - Mailing list pgsql-admin

From Bruce Momjian
Subject Re: Require Assistance Solving Problem - erroneous pg_hba.conf
Date
Msg-id 200304171713.h3HHDCs07884@candle.pha.pa.us
Whole thread Raw
In response to Re: Require Assistance Solving Problem - erroneous pg_hba.conf  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-admin
Yep, makes sense.  This is clearly our bug because we overrode a
standard C function with one that didn't behave the same.  My man page
says isblank tests only for space and tab, while we added \r to handle
DOS files cleanly.

---------------------------------------------------------------------------

Tom Lane wrote:
> "Greg Kelley" <gkelley@britannicaviation.com> writes:
> > A RedHat Upgrade  Saturday from 8.0 to 9.0 just did a 'minor' version
> > upgrade from 7.3.1 to 7.3.2.
> > [ and broke his pg_hba.conf ]
>
> Ah-hah, I now know where the behavioral change came from: the Red Hat
> RPMs contain this patch:
>
> --- postgresql-7.3.2/src/backend/libpq/hba.c.sopwith    2003-01-09 09:09:01.000000000 -0500
> +++ postgresql-7.3.2/src/backend/libpq/hba.c    2003-01-09 09:09:09.000000000 -0500
> @@ -72,11 +72,13 @@
>   * Some standard C libraries, including GNU, have an isblank() function.
>   * Others, including Solaris, do not.  So we have our own.
>   */
> +#ifndef isblank
>  static bool
>  isblank(const char c)
>  {
>         return c == ' ' || c == '\t' || c == '\r';
>  }
> +#endif
>
>
>  /*
>
> which on RHL 9 causes the system definition of isblank() to be
> substituted for Postgres'.  That means \r is no longer treated as
> whitespace, as it was in prior versions.
>
> There is a fix in our CVS tree that prevents this problem and restores
> the old treatment of \r, but for now you gotta get rid of the Windows-
> style newlines.
>
>             regards, tom lane
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073


pgsql-admin by date:

Previous
From: "Greg Kelley"
Date:
Subject: Re: Require Assistance Solving Problem - erroneous pg_hba.conf
Next
From: dalgoda@ix.netcom.com (Mike Castle)
Date:
Subject: Re: Require Assistance Solving Problem - erroneous pg_hba.conf