Re: orderRules() now a bad idea? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: orderRules() now a bad idea?
Date
Msg-id 200210142253.g9EMrR129164@candle.pha.pa.us
Whole thread Raw
In response to orderRules() now a bad idea?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: orderRules() now a bad idea?
List pgsql-hackers
Tom Lane wrote:
> I just noticed that rewriteHandler.c contains a subroutine orderRules()
> that reorders the rules for a relation into the order
>     non-instead rules
>     qualified instead rules
>     unqualified instead rules
> This conflicts with the feature we'd added to 7.3 to fire rules in
> alphabetical order.  (What will presently happen is they'll be fired
> alphabetically in each of these categories.)
> 
> I see that the logic in fireRules() assumes that rules are processed in
> this order, but that would be fairly easy to fix.  Is there any other
> good reason for doing this reordering?  I'd like to remove orderRules()
> and implement straight alphabetical ordering.

Unless Jan has an objection, I think alpha is best, because it matches
trigger rule odering.  That original rule ordering isn't something
anyone is going to figure out on their own.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: droped out precise time calculations in src/interfaces/libpq/fe-connect.c
Next
From: Bruce Momjian
Date:
Subject: Re: interesting side effect of autocommit = off