Oops, overoptimized a little. ptmp_timeout is needed in case no time is
passed; ptmp_timeout restored.
---------------------------------------------------------------------------
pgman wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > That whole remains structure should be a time_t variable, and then we
> > > _know_ we can't assume it is signed. The use of timeval should
> > > happen only in pqWaitTimed because it has to use select().
> >
> > I think it's fine to use struct timeval as the parameter type for
> > pqWaitTimed. This particular caller of pqWaitTimed has no need for
> > sub-second wait precision, but that doesn't mean we might not want it
> > for other purposes later.
>
> That was a question: whether pqWaitTimed() was something exported by
> libpq and therefore something that has an API that shouldn't change. I
> see it in libpq-int.h, which I think means it isn't exported, but yes,
> there could be later cases where we need subsecond stuff.
>
> I have applied the following patch to get us a little closer to sanity.
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610)
359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square,
Pennsylvania19073
