Re: pgsql-server/src/backend executor/nodeAgg.c ut ... - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql-server/src/backend executor/nodeAgg.c ut ...
Date
Msg-id 200210041736.g94HacG25944@candle.pha.pa.us
Whole thread Raw
In response to pgsql-server/src/backend executor/nodeAgg.c ut ...  (tgl@postgresql.org (Tom Lane))
List pgsql-committers
Tom Lane wrote:
> CVSROOT:    /cvsroot
> Module name:    pgsql-server
> Changes by:    tgl@postgresql.org    02/10/04 13:19:55
>
> Modified files:
>     src/backend/executor: nodeAgg.c
>     src/backend/utils/fmgr: fmgr.c
>     src/backend/utils/sort: tuplesort.c
>
> Log message:
>     Tweak a few of the most heavily used function call points to zero out
>     just the significant fields of FunctionCallInfoData, rather than MemSet'ing
>     the whole struct to zero.  Unused positions in the arg[] array will
>     thereby contain garbage rather than zeroes.  This buys back some of the
>     performance hit from increasing FUNC_MAX_ARGS.  Also tweak tuplesort.c
>     code for more speed by marking some routines 'inline'.  All together
>     these changes speed up simple sorts, like count(distinct int4column),
>     by about 25% on a P4 running RH Linux 7.2.

Wow, huge win.  Thanks, Tom.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql-server/src/backend/utils/adt nabstime.c
Next
From: Neil Conway
Date:
Subject: Re: pgsql-server/src/backend executor/nodeAgg.c ut ...