Re: contrib/ltree for 7.2 or 7.3 ? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: contrib/ltree for 7.2 or 7.3 ?
Date
Msg-id 200208060627.g766Ri515391@candle.pha.pa.us
Whole thread Raw
In response to Re: contrib/ltree for 7.2 or 7.3 ?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: contrib/ltree for 7.2 or 7.3 ?  (Oleg Bartunov <oleg@sai.msu.su>)
Re: contrib/ltree for 7.2 or 7.3 ?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Folks, has this been fixed?

---------------------------------------------------------------------------

Tom Lane wrote:
> > Oleg Bartunov wrote:
> >> One known issue: It'll not works with 64-bit OS. We'll certainly fix this
> >> but will appreciate if somebody with access to 64-bit machine could help us.
> 
> Actually, it dumps core instantly on 32-bit machines too, if they are
> pickier about alignment than Intel hardware is.  You can't map
> structures onto char[] arrays that start at odd byte offsets and not
> expect trouble.
> 
> I also do not trust macros like this:
> 
> typedef struct {
>     int32    len;
>     uint16    numlevel;
>     char    data[1];
> } ltree;
> 
> #define LTREE_HDRSIZE    ( sizeof(int32) + sizeof(uint16) )
> 
> because they take no account of the possibility of padding between fields.
> 
>             regards, tom lane
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: New manual chapters
Next
From: Bruce Momjian
Date:
Subject: DB-local usernames