Re: pgsql/ ontrib/dbsize/dbsize.c ontrib/fulltexti ... - Mailing list pgsql-committers

Well, I assume those changes were valid t_oid changes required.  I see:

        dbid = HeapTupleGetOid(tuple);

in dbsize.c, and I guess it used to access t_oid.

---------------------------------------------------------------------------

Christopher Kings-Lynne wrote:
> Bruce - are you aware that you (probably accidentally) committed several
> changes in /contrib with this commit?
>
> Chris
>
> On Sat, 20 Jul 2002, Bruce Momjian - CVS wrote:
>
> > CVSROOT:    /cvsroot
> > Module name:    pgsql
> > Changes by:    momjian@postgresql.org    02/07/20 01:16:59
> >
> > Modified files:
> >     contrib/dbsize : dbsize.c
> >     contrib/fulltextindex: fti.c
> >     contrib/rserv  : rserv.c
> >     src/backend/access/common: heaptuple.c tupdesc.c
> >     src/backend/access/heap: heapam.c tuptoaster.c
> >     src/backend/bootstrap: bootparse.y bootstrap.c
> >     src/backend/catalog: aclchk.c heap.c index.c namespace.c
> >                          pg_operator.c pg_proc.c pg_type.c
> >     src/backend/commands: comment.c copy.c dbcommands.c explain.c
> >                           functioncmds.c indexcmds.c proclang.c
> >                           tablecmds.c trigger.c typecmds.c vacuum.c
> >                           vacuumlazy.c
> >     src/backend/executor: execJunk.c execMain.c execQual.c
> >                           execTuples.c execUtils.c
> >                           nodeFunctionscan.c spi.c
> >     src/backend/optimizer/util: clauses.c
> >     src/backend/parser: parse_oper.c parse_type.c
> >     src/backend/postmaster: pgstat.c
> >     src/backend/rewrite: rewriteRemove.c
> >     src/backend/utils/adt: regproc.c sets.c
> >     src/backend/utils/cache: catcache.c inval.c relcache.c
> >                              syscache.c
> >     src/backend/utils/init: postinit.c
> >     src/backend/utils/misc: database.c
> >     src/include    : pg_config.h.in
> >     src/include/access: heapam.h htup.h tupdesc.h
> >     src/include/executor: executor.h
> >     src/pl/plpython: plpython.c
> >     src/pl/tcl     : pltcl.c
> >     src/test/regress: parallel_schedule serial_schedule
> >
> > Log message:
> >     oid is needed, it is added at the end of the struct (after the null
> >     bitmap, if present).
> >
> >     Per Tom Lane's suggestion the information whether a tuple has an oid
> >     or not is carried in the tuple descriptor.  For debugging reasons
> >     tdhasoid is of type char, not bool.  There are predefined values for
> >     WITHOID, WITHOUTOID and UNDEFOID.
> >
> >     This patch has been generated against a cvs snapshot from last week
> >     and I don't expect it to apply cleanly to current sources.  While I
> >     post it here for public review, I'm working on a new version against a
> >     current snapshot.  (There's been heavy activity recently; hope to
> >     catch up some day ...)
> >
> >     This is a long patch;  if it is too hard to swallow, I can provide it
> >     in smaller pieces:
> >
> >     Part 1:  Accessor macros
> >     Part 2:  tdhasoid in TupDesc
> >     Part 3:  Regression test
> >     Part 4:  Parameter withoid to heap_addheader
> >     Part 5:  Eliminate t_oid from HeapTupleHeader
> >
> >     Part 2 is the most hairy part because of changes in the executor and
> >     even in the parser;  the other parts are straightforward.
> >
> >     Up to part 4 the patched postmaster stays binary compatible to
> >     databases created with an unpatched version.  Part 5 is small (100
> >     lines) and finally breaks compatibility.
> >
> >     Manfred Koizar
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
> >
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026